Difference between revisions of "Talk:Files/EditBufHacks"
| Line 1: | Line 1: | ||
| − | We should add a config to select which archive has this feature and which not, otherwise in multiarchive conf we send email even if not required. | + | It works. |
| + | |||
| + | A couple of improvments: | ||
| + | |||
| + | a - We should add a config to select which archive has this feature and which not, otherwise in multiarchive conf we send email even if not required. Luckly, modifind the global cgi edit_eprints don't create problems . | ||
| + | |||
| + | b- The check: | ||
| + | |||
| + | <nowiki>my $start_work = EPrints::Utils::tree_to_utf8( $user->render_value("onlinemail") ); | ||
| + | if ($start_work eq 'Yes') </nowiki> | ||
| + | |||
| + | is language dependant and works only for English repositories. I suggest to change it in something like this: | ||
| + | |||
| + | <nowiki> my $start_work = $user->{"onlinemail"}; | ||
| + | if ($start_work eq 'True') { | ||
| + | </nowiki> | ||
Revision as of 09:21, 3 June 2007
It works.
A couple of improvments:
a - We should add a config to select which archive has this feature and which not, otherwise in multiarchive conf we send email even if not required. Luckly, modifind the global cgi edit_eprints don't create problems .
b- The check:
my $start_work = EPrints::Utils::tree_to_utf8( $user->render_value("onlinemail") ); if ($start_work eq 'Yes')
is language dependant and works only for English repositories. I suggest to change it in something like this:
my $start_work = $user->{"onlinemail"};
if ($start_work eq 'True') {
