Difference between revisions of "Talk:Files/EditBufHacks"
m |
|||
| (8 intermediate revisions by the same user not shown) | |||
| Line 1: | Line 1: | ||
| − | We should add a config to select which archive has this feature and which not, otherwise in multiarchive conf we send email even if not required. | + | It works. |
| + | |||
| + | A couple of improvments: | ||
| + | |||
| + | a - We should add a config to select which archive has this feature and which not, otherwise in multiarchive conf we send email even if not required. Luckly, modifing the global cgi edit_eprints don't create problems (even with the modification below). '''It should not be so''', cause $user->get_value( 'onlinemail' ) should abort() (in DataObj.pm) if the field is non existant. | ||
| + | |||
| + | b- The check: | ||
| + | |||
| + | my $start_work = EPrints::Utils::tree_to_utf8( $user->render_value("onlinemail") ); | ||
| + | if ($start_work eq 'Yes') | ||
| + | |||
| + | |||
| + | is language dependant and works only for English repositories. I suggest to change it in something like this: | ||
| + | |||
| + | my $start_work = $user->get_value( 'onlinemail' ); | ||
| + | if ($start_work eq 'TRUE') { | ||
Latest revision as of 09:44, 3 June 2007
It works.
A couple of improvments:
a - We should add a config to select which archive has this feature and which not, otherwise in multiarchive conf we send email even if not required. Luckly, modifing the global cgi edit_eprints don't create problems (even with the modification below). It should not be so, cause $user->get_value( 'onlinemail' ) should abort() (in DataObj.pm) if the field is non existant.
b- The check:
my $start_work = EPrints::Utils::tree_to_utf8( $user->render_value("onlinemail") );
if ($start_work eq 'Yes')
is language dependant and works only for English repositories. I suggest to change it in something like this:
my $start_work = $user->get_value( 'onlinemail' );
if ($start_work eq 'TRUE') {
