Difference between revisions of "Talk:Files/EditBufHacks"

From EPrints Documentation
Jump to: navigation, search
Line 8: Line 8:
  
 
<nowiki>my $start_work = EPrints::Utils::tree_to_utf8( $user->render_value("onlinemail") );
 
<nowiki>my $start_work = EPrints::Utils::tree_to_utf8( $user->render_value("onlinemail") );
  if ($start_work eq 'Yes') </nowiki>
+
if ($start_work eq 'Yes')
 +
</nowiki>
  
 
  is language dependant and works only for English repositories. I suggest to change it in something like this:
 
  is language dependant and works only for English repositories. I suggest to change it in something like this:
  
  <nowiki> my $start_work = $user->{"onlinemail"};
+
<nowiki>my $start_work = $user->{"onlinemail"};
  if ($start_work eq 'True') {
+
if ($start_work eq 'True') {
 
</nowiki>
 
</nowiki>

Revision as of 09:22, 3 June 2007

It works.

A couple of improvments:

a - We should add a config to select which archive has this feature and which not, otherwise in multiarchive conf we send email even if not required. Luckly, modifind the global cgi edit_eprints don't create problems .

b- The check:

my $start_work = EPrints::Utils::tree_to_utf8( $user->render_value("onlinemail") ); if ($start_work eq 'Yes')

is language dependant and works only for English repositories. I suggest to change it in something like this:

my $start_work = $user->{"onlinemail"}; if ($start_work eq 'True') {