Editing EPrints 3.4.6 (section)

== Known Issues ==
=== Running generate_apacheconf with an archive without a cfg/static/javascript/auto/ directory ===
If you are upgrading an EPrints repository and your archive(s) do not have a <code>cfg/static/javascript/auto/</code> directory then <code>bin/generate_apacheconf</code> will fail.  This is because 3.4.5 [https://github.com/eprints/eprints3.4/issues/286 introduces] code that makes sure that the maximum upload limit is configured to be the same in the Apache configuration and in EPrints' JavaScript, which prevents you from trying to upload files larger than a certain size.  This is useful because if you just updated the JavaScript, EPrints would allow the upload to start but would then fail when the Apache limit was reached.  So not only would you not be able to upload the file but you would waste a load of time and possibly not understand why the upload failed.

To fix this issue for this version of EPrints, just make sure your archive (or archives) all have a <code>cfg/static/javascript/auto/</code> before running <code>bin/generate_apacheconf</code>.  Future versions of EPrints will automatically create this directory if it does not already exist.

=== Subject search does not work in workflows ===
If you have a subject field which renders as a subject tree in a workflow, the search form will not work.  This is due to the [https://github.com/eprints/eprints3.4/issues/246 fix for ensuring Xapian respect a MetaField's <tt>text_index</tt> value].  This has the consequence of not indexing the <tt>ancestors</tt> field for subjects.  This is used by the search to filter out subjects that are not part of the subject sub-tree for a particular MetaField.  [https://github.com/eprints/eprints3.4/commit/3fbd47ccc0d9e66514455c693b62b902790e3326 This patch] fixes [https://github.com/eprints/eprints3.4/issues/411 the issue].  However, you will also need to re-index all subjects:
 EPRINTS_PATH/bin/epadmin reindex ARCHIVE_ID subject

=== Approved document requests still force user to login ===
This issue was caused by setting the <code>samesite</code> attribute for the <code>eprints_doc_request</code> cookie to <code>Strict</code>, this cookie is intended to allow the user to access the restricted document for the remainder of their session.  Changing this attributes means some browsers (e.g. Firefox) still send the user to a login page even when clicking the approved request link in the email they received.  This is because the change made to the cookie prevents its from being stored because <code>/cgi/process_request</code> never fully serves a page.  [https://github.com/eprints/eprints3.4/commit/278b5e599dc9f6aa1e4a20f3b211afabb2a4ea9a This patch] fixes the [https://github.com/eprints/eprints3.4/issues/413 the issue].

=== File uploads not check for size ===
If you use the "Browse..." or "Choose File" button to upload files using the file dialogue (drag 'n' drop is unaffected) it will not check if the size is above the maximum permitted according to <code>$c->{max_upload_filesize}</code>.  If you do it will reach 100% but then it won't ever say it is complete and teh file won't actually have successfully uploaded. [https://github.com/eprints/eprints3.4/commit/2467b680373ac7be831e729a50c632ba7ec15e85This patch] fixes the [https://github.com/eprints/eprints3.4/issues/406 the issue].